updated for jruby-kafka 0.2.1, style and documentation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated Kafka output sendMsg to send_msg * style fixes * fix Kafka output test to use send_msg
| @@ -17,7 +17,7 @@ Gem::Specification.new do |s| | |||
| s.test_files = s.files.grep(%r{^(test|spec|features)/}) | |||
|
|
|||
| # Special flag to let us know this is actually a logstash plugin | |||
| s.metadata = { "logstash_plugin" => "true", "group" => "output" } | |||
| s.metadata = { :logstash_plugin => 'true', :group => 'output'} | |||
|
Updated. |
suyograo
added a commit
that referenced
this pull request
Oct 8, 2014
updated for jruby-kafka 0.2.1, style and documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created per request: elastic/logstash#1764
The fix from elastic/logstash#1738 seemed to slip by this output so I added the fix to this PR as well.